-
Notifications
You must be signed in to change notification settings - Fork 48
Update for QueryProfiler UI - Added Queue time, and Run Time #1350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fixed test
lcoffinOT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to add a new test case validating the new timing fields. Maybe check that they're always positive values (or 0), and that queue time is less than completion time.
lcoffinOT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mail4umar thanks for the update! I still think we should include new test cases with this PR as well (see my previous review comment #1350 (review) ). If this needs review again while I'm out, can you pull Danny in?
This will be a bit problematic. Because we will not create a scenario where the resources are strained and there is a queue time. In the code it is only pulling out the values from the resource_acq table. I am sure that table will have checks in place for making sure that there are no negative values etc. |
My thought is that we are pulling directly from Vertica for this data. If this test failed, it would point to an issue in Vertica, not qprof. For that reason I believe that test would be unnecessary |
|
Looks good to me, but seems like it's failing the tests now? Or am I reading the 'Some checks were not successful' box wrong? |
|
I did not mean to close this 😅 |
Previous "Execution Time" in the Summary tab was a bit misleading.
Now we are adding three times: